Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf2: fix computation of tilt and yaw variances #22674

Merged
merged 2 commits into from
Jan 24, 2024
Merged

ekf2: fix computation of tilt and yaw variances #22674

merged 2 commits into from
Jan 24, 2024

Conversation

bresch
Copy link
Member

@bresch bresch commented Jan 24, 2024

Also log yaw and tilt variance

@bresch bresch added the EKF2 label Jan 24, 2024
@bresch bresch requested a review from dagar January 24, 2024 16:13
@bresch bresch self-assigned this Jan 24, 2024
float32 unaided_heading # Same as heading but generated by integrating corrected gyro data only
float32 delta_heading # Heading delta caused by latest heading reset [rad]
uint8 heading_reset_counter # Index of latest heading reset
bool heading_good_for_control

float32 tilt_var
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge for now, but I think we should move this to vehicle_attitude instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I convinced myself that it had its place in there because it's the uncertainty of the attitude defined in the local frame, but you're probably right

@dagar dagar merged commit cb396a6 into main Jan 24, 2024
3 checks passed
@dagar dagar deleted the pr-ekf2-att-var branch January 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants