Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Precision loiter [WIP] #23012

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Precision loiter [WIP] #23012

wants to merge 1 commit into from
+791 −4

Conversation

asimopunov
Copy link
Contributor

@asimopunov asimopunov commented Apr 12, 2024 •
edited
Loading

@asimopunov asimopunov force-pushed the precloiter branch 3 times, most recently from 8922810 to c38e3c4 Compare April 12, 2024 05:26
@bresch
Copy link
Member

bresch commented Apr 12, 2024

Added “precision loiter” functionality which is identical to precision land except hovers
over the target instead of landing on it.

I would then say that instead of copy pasting and modifying precision landing you should rather split precision landing into "approach", "search" and "landing". Then you can have all of them for precision landing and just remove landing in precision hover. (when I say split, I mean "refactor" and "extract to a separate class that can be used by both modes")

@github-actions github-actions bot added the stale label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asimopunov @bresch