-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-0019 Precision Target MAV_SYS_STATUS extension #21
base: master
Are you sure you want to change the base?
Conversation
5ebb476
to
fc20ed0
Compare
ebf30f8
to
5681e61
Compare
5681e61
to
c4aef92
Compare
Further thoughts on how the MAV_SYS_STATUS bitfields are populated present
enabled healthy |
@akkawimo |
|
||
# Detailed Design | ||
|
||
MAVLink already supports the concept of "Sensor Status" via the MAV_SYS_STATUS_SENSOR and MAV_SYS_STATUS_SENSOR_EXTENDED bitmasks in the [SYS_STATUS](https://mavlink.io/en/messages/common.html#SYS_STATUS) message. I have implemented this functionality using MAV_SYS_STATUS_SENSOR_XY_POSITION_CONTROL but I propose that we create a new purpose built bitmask MAV_SYS_STATUS_SENSOR_PRECISION_TARGETTING. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you're doing with MAV_SYS_STATUS_SENSOR_XY_POSITION_CONTROL below, but what's the proposal for MAV_SYS_STATUS_SENSOR_PRECISION_TARGETTING (I might be missing something obvious)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dakejahl Note, not sure how you want me to progress this. But I'll keep an eye out for your comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposal is to just add this new flag MAV_SYS_STATUS_SENSOR_PRECISION_TARGETTING since "XY position control" isn't really accurate -- to me "xy position control" makes me think of an optical flow or VIO system. There are already flags for vision and optical flow tho... just seems like a lot of these flags are unused and not well thought out in the first place. A flag that clearly says "precision targetting" in the name seems more appropriate, and would probably be acceptable (in terms of language) to both px4/ardu peeps
This would also support status reporting for PRECISION_HOLD
mavlink/mavlink#1858