Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: add crsfrc driver to ark flight controllers #23063

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AlexKlimaj
Copy link
Member

@AlexKlimaj AlexKlimaj commented Apr 28, 2024

This PR adds the standalone crfs_rc driver to the ark flight controllers. I also added a parameter to start the CRSF_RC driver with a parameter. If it is enabled, the normal rc_input driver is not started.

@AlexKlimaj AlexKlimaj requested a review from dagar April 28, 2024 01:56
@PetervdPerk-NXP
Copy link
Member

Any reason to keep crsf_telemetry.cpp alive? In the long-term this is going to be very confusing for the end-users.

Even myself have to still figure this out and the manual doesn't seem to mention this.
https://docs.px4.io/main/en/telemetry/crsf_telemetry.html#px4-configuration

@AlexKlimaj
Copy link
Member Author

Any reason to keep crsf_telemetry.cpp alive? In the long-term this is going to be very confusing for the end-users.

Even myself have to still figure this out and the manual doesn't seem to mention this. https://docs.px4.io/main/en/telemetry/crsf_telemetry.html#px4-configuration

Ultimately we need to merge #20829
Those docs are confusing since there is a rc_input/crsf_telemetry.cpp but the docs refer to this crsf_rc driver.

@AlexKlimaj
Copy link
Member Author

Copy link
Member

@PetervdPerk-NXP PetervdPerk-NXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested an ELRS receiver with telemetry on V6X-RT that's looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants