Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIH - change how LAT and LON is used for Takeoff location #23363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Claudio-Chies
Copy link

@Claudio-Chies Claudio-Chies commented Jul 5, 2024

Solved Problem

for SIH the Lat and Long parameter was set in an inconsistent way, unlike how gazebo (before #22638) and gazebo classic handled it.
it used an int which it converted to a float, meaning if you copy and paste WGS84 coordinates you hat to manually remove the comma and add zeros.
PX4 Docs: PX4/PX4-user_guide#3275

Solution

change from int to float, allowing easy copy and paste of WGS84 coordinates.

Changelog Entry

For release notes:

Feature/Bugfix fix of inconsistent parameter handling for SIH
New parameter: -
Documentation: See PX4-Docs

Test coverage

Tested in SITL

@Claudio-Chies Claudio-Chies marked this pull request as ready for review July 5, 2024 08:07
@Claudio-Chies Claudio-Chies changed the title change how LAT and LON is used for SIH SIH - change how LAT and LON is used for Takeoff location Jul 5, 2024
@Claudio-Chies Claudio-Chies marked this pull request as draft July 5, 2024 08:15
Jaeyoung-Lim
Jaeyoung-Lim previously approved these changes Jul 5, 2024
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Claudio-Chies Claudio-Chies marked this pull request as ready for review July 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants