Fix tiltrotor model and add to SITL testing #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSC21
reviewed
Aug 25, 2020
Jaeyoung-Lim
force-pushed
the
pr-fix-tiltrotor
branch
from
9827f41
to
e8da78a
Compare
|
I am not sure, but think that this should be changed: to |
Move where the gps joint is being defined inside the sdf file, based on the review comments
Jaeyoung-Lim
force-pushed
the
pr-fix-tiltrotor
branch
from
1f49d1a
to
d9e2527
Compare
|
@BazookaJoe1900 Could you clarify why? |
|
because of the symmetry to the right_elevon: |
|
Closing since there are too many intermittent failures for this model Will reopen when there is time to revisit |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tiltrotor model that was failing SITL testing before, and adds the tests to mavsdk testing