-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: build xenial-base using Github actions #225
Conversation
89db13f
to
79aa280
Compare
79aa280
to
f871f13
Compare
f871f13
to
e8e7c9e
Compare
This takes forever and currently fails anyway.
@julianoes is there a specific reason we are moving to Github Actions? |
@TSC21 I just wanted to experiment if that could be faster and more transparent. The way via dockerhub is slow and hard to understand. |
a7b37ca
to
adaecec
Compare
adaecec
to
ea3980f
Compare
a798763
to
66c1b92
Compare
6841e1f
to
2ca621e
Compare
This should prevent that a -stages repo is created.
2ca621e
to
d2818fd
Compare
Otherwise the setuptools are too old and cause install failures.
d2818fd
to
837c21e
Compare
This now works for the two base images. The question is how this could work for images on top of the base image. The problem is that we reference the tag in the Dockerfile but that tag has not been built yet. So essentially we can't reference thebase in the pull request as it will always fail. We could reference to An alternative would be not to build anything in the PR and then build it all using |
@julianoes I don't really like the idea of using the |
@TSC21 I lean towards building everything on master but not in the pull request. |
4ad070f
to
a4e421f
Compare
Let's try to use this instead of building on dockerhub.