Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: build xenial-base using Github actions #225

Merged
merged 13 commits into from
Jan 10, 2020

Conversation

julianoes
Copy link
Contributor

Let's try to use this instead of building on dockerhub.

@TSC21
Copy link
Member

TSC21 commented Jan 7, 2020

@julianoes is there a specific reason we are moving to Github Actions?

@julianoes
Copy link
Contributor Author

@TSC21 I just wanted to experiment if that could be faster and more transparent. The way via dockerhub is slow and hard to understand.

@julianoes julianoes force-pushed the pr-add-github-actions branch 3 times, most recently from a7b37ca to adaecec Compare January 8, 2020 08:29
@julianoes julianoes force-pushed the pr-add-github-actions branch 3 times, most recently from a798763 to 66c1b92 Compare January 8, 2020 11:21
@julianoes julianoes force-pushed the pr-add-github-actions branch 4 times, most recently from 6841e1f to 2ca621e Compare January 8, 2020 12:42
This should prevent that a -stages repo is created.
Otherwise the setuptools are too old and cause install failures.
@julianoes
Copy link
Contributor Author

julianoes commented Jan 8, 2020

This now works for the two base images. The question is how this could work for images on top of the base image. The problem is that we reference the tag in the Dockerfile but that tag has not been built yet. So essentially we can't reference thebase in the pull request as it will always fail. We could reference to latest and push to latest in a PR but then different PRs would conflict.

An alternative would be not to build anything in the PR and then build it all using latest once merged to master.
Another way would be to only build on tag (like dockerhub), and at that point correctly follow the tags by building in the right order.

@TSC21 @dagar better ideas?

@TSC21
Copy link
Member

TSC21 commented Jan 8, 2020

@julianoes I don't really like the idea of using the latest tag, but if there's no other solution, we might have to use it.

@julianoes
Copy link
Contributor Author

@TSC21 I lean towards building everything on master but not in the pull request.

@julianoes julianoes merged commit a58fa4d into master Jan 10, 2020
@julianoes julianoes deleted the pr-add-github-actions branch January 10, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants