Adapt to sonarqube version 6.0 and fixed some java 8.0 warnings

[huberchrigu]

Hi. The sq6support branch was not running on Sonarqube 6.0. So I fixed it. Now it runs well again, incl. test coverage. If you like, merge my changes.

All the best and thanks for the plugin
Christoph

[coveralls]

Coverage decreased (-0.1%) to 71.19% when pulling f4b502a on huberchrigu:sq6support into 981acfa on Pablissimo:sq6support.

[Pablissimo]

What was the error you were getting with SQ6? I had it running locally so am unsure what is wrong there - targeting the 6.0 API presumably means that it breaks compatibility with the 5.6 LTS version of SQ?

[huberchrigu]

I got a ClassNotFoundException for Guava's Objects class because SQ is not using Google Guava anymore. This could not be reproduced at compile-time since the old SQ dependencies use Guava, that's why I set it to 6.0. I'm not sure about the backwards compatibility. So if you want, you can just overtake the changes in LCOVParserImpl.java and keep the SQ version.

[Pablissimo]

Interesting... Will try and repro, I did have some trouble with it originally, so am wondering what I've done in my environment now!

-------- Original message --------
From: Christoph Huber notifications@github.com
Date: 06/10/2016 15:18 (GMT+00:00)
To: Pablissimo/SonarTsPlugin SonarTsPlugin@noreply.github.com
Cc: Pablissimo turnacre@hotmail.com, Comment comment@noreply.github.com
Subject: Re: [Pablissimo/SonarTsPlugin] Adapt to sonarqube version 6.0 and fixed some java 8.0 warnings (#57)

I got a ClassNotFoundException for Guava's Objects class because SQ is not using Google Guava anymore. This could not be reproduced at compile-time since the old SQ dependencies use Guava, that's why I set it to 6.0. I'm not sure about the backwards compatibility. So if you want, you can just overtake the changes in LCOVParserImpl.java and keep the SQ version.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com//pull/57#issuecomment-251975931, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABZvgFIaPASEqBuw0wAngHX8YZa-XkQnks5qxQM4gaJpZM4KP6zi.