Draft: Port static methods of Transaction & Daemon from QString to QStringView #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tringView This is API and ABI breaking change. It optimizes extra allocations for all four methods where returned value is a slice of their input string.
|
So, I tried to port KDE/Plasma Discover in couple of files, and found it to be quite pointless. Due to the lack of overloaded API elsewhere, I ended up just appending Other than that, these methods should probably be added as overloads in addition to existing ones. Imaging passing rvalue QString to one of such methods, and get a QStringView which points to an already destructed temporary QString object? Lifetimes disaster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is API and ABI breaking change. It optimizes extra allocations for all four methods where returned value is a slice of their input string.
Fixes #55