Fix chapter08 dependent

[iankode]

resolves Issue #7

[marcinjamro]

Hello!

Thank you for submitting your changes to the code. It looks like someone has modified the code I included in the book and made changes that make it incorrect. As soon as I received notifications about your pull requests, I immediately contacted the publisher and asked to use the exact same version of the code that I provided. I would like to apologize for this situation, but it was not caused by me. I hope the publisher fixes this as soon as possible.

Thanks again for your help and I hope that you enjoy the book!

Have a nice day!
Marcin

[iankode]

Marcin, Hi Thank you for your prompt reply. I wasn't sure if you were responding to my Issues/PRs or the supplementary email[below] I sent to Packt to alert interested parties - no matter as I am sure you will drive through the necessary changes I was considering a couple of other niggles that I may get around to proposing [work permitting] * Regex assignment within loop [Chapter07\AutoComplete\ Program.cs], whereas hoisted or generated much preferred * general latest C# (v12 Nov 2023) semantics but no promises! We will see whether Packt admit to tinkering during the final polish, and whether they Credit me [read-receipts OK but no reply yet]. I note your mention of upcoming training so please keep me posted. Best wishes, IanK From: Marcin Jamro ***@***.***> Sent: Tuesday, May 7, 2024 11:13 AM To: PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition ***@***.***> Cc: iankode ***@***.***>; Author ***@***.***> Subject: Re: [PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition] Fix chapter08 dependent (PR #8) Hello! Thank you for submitting your changes to the code. It looks like someone has modified the code I included in the book and made changes that make it incorrect. As soon as I received notifications about your pull requests, I immediately contacted the publisher and asked to use the exact same version of the code that I provided. I would like to apologize for this situation, but it was not caused by me. I hope the publisher fixes this as soon as possible. Thanks again for your help and I hope that you enjoy the book! Have a nice day! Marcin - Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARYJPSM7N2NFCEJLR7HPPJTZBCSLFAVCNFSM6AAAAABHKRVX3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXHE2DINRWHA>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> From: Ian Kode ***@***.******@***.***> Sent: Tuesday, May 7, 2024 10:28 AM To: ***@***.******@***.***> Cc: 'Packt Customer Care' ***@***.******@***.***> Subject: "C# Data Structures and Algorithms - Second Edition" ISBN 9781803248271 Dear Packt, I have been reading a colleague's copy of this book<https://www.packtpub.com/product/c-data-structures-and-algorithms-second-edition/9781803248271>, but I found several errors with the code download<https://github.com/PacktPublishing/C-Sharp-Data-Structures-and-Algorithms---Second-Edition/tree/main> (as hosted on GitHub) - I have now raised 4x Issues (problem statements) and 4x Pull Requests (suggestions for improvement) related on GH (see links below) Problem Issue PR Missing standard GH files #1<#1> #2<#2> Chapter03 project doesn't compile #3<#3> #4<#4> Chapter07 project doesn't compile #5<#5> #6<#6> Chapter08 project doesn't compile #7<#7> #8<#8> These are provided with goodwill to author Dr Jamro and Packt as enhancement (please review and consider for update and any 3e release) - please cascade this email (+links) to author for his analysis (although Packt techies should also investigate) Would be nice to receive Credits from Packt to justify my time & effort preparing these contributions :) Regards, IanK

[marcinjamro]

Hello!

Thank you for the reply. I hope the publisher will quickly replace the code with its correct version. I must admit that I was very surprised by what I saw in the repository, because unfortunately it was not what I sent to the publisher. Anyway, thank you very much for drawing attention to the problem, because it was thanks to your feedback that I learned about the problem and was also able to react. This will have a positive impact on other developers who want to use the code, as well. So, thank you once again!

Once the publisher places the correct version in the repository, I will be happy to hear your ideas on how the code could be further improved. Feel free to let me know! Each such feedback is very valuable and thanks to it we can further improve our skills. I would also like to get to know you, so if you want, please add me as your friend on LinkedIn.

Have a nice day!
Marcin