Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则No66-70 torch.nn.functional.pairwise_distance #118

Merged
merged 34 commits into from
Sep 5, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Jun 23, 2023

PR Docs

None

PR APIs

torch.nn.functional.cosine_embedding_loss
torch.nn.functional.gumbel_softmax
torch.nn.functional.hinge_embedding_loss
torch.nn.functional.pairwise_distance
torch.nn.functional.poisson_nll_loss

API Discriptions

#112 case 67
poisson_nll_loss 参数 full会导致计算差异

@paddle-bot
Copy link

paddle-bot bot commented Jun 23, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 23, 2023
paconvert/api_mapping.json Outdated Show resolved Hide resolved
paconvert/api_mapping.json Outdated Show resolved Hide resolved
paconvert/api_mapping.json Outdated Show resolved Hide resolved
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 26, 2023
@Liyulingyue Liyulingyue changed the title [convert] torch.nn.functional.pairwise_distance 转换规则No67 torch.nn.functional.pairwise_distance Jun 27, 2023
@zhwesky2010
Copy link
Collaborator

@Liyulingyue 上面的评论回复一下

"reduce",
"reduction"
],
"kwargs_change": {
Copy link
Collaborator

@zhwesky2010 zhwesky2010 Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个写错了吧,torch的参数没有dim、tau,paddle的参数没有epsilon、axis、temperature

https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/nn/functional/poisson_nll_loss_cn.html#poisson-nll-loss

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,我改一下~

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Liyulingyue 有些文档都有bug,需要仔细核对下,如果文档有bug需要进行修复

infoflow 2023-08-29 11-09-46 infoflow 2023-08-29 11-10-56

@zhwesky2010
Copy link
Collaborator

这个错误可以再确认一下,是不是full=True时存在计算bug,我们会记录相应bug

@luotao1
Copy link
Collaborator

luotao1 commented Jul 27, 2023

@Liyulingyue 请补充下转换文档

@luotao1
Copy link
Collaborator

luotao1 commented Aug 18, 2023

@Liyulingyue 请解决下冲突和回答下上面的问题

"reduce",
"reduction"
],
"kwargs_change": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,我改一下~

paconvert/api_mapping.json Outdated Show resolved Hide resolved
@Liyulingyue
Copy link
Contributor Author

Member

solved~

@zhwesky2010
Copy link
Collaborator

映射文档写了吗?

@Liyulingyue
Copy link
Contributor Author

映射文档写了吗?

应该还没有,我稍后确认一下~

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Aug 23, 2023

映射文档写了吗?

应该还没有,我稍后确认一下~

这个需要先写映射关系文档,再写转换规则的

infoflow 2023-08-23 21-26-37

@zhwesky2010
Copy link
Collaborator

@Liyulingyue 你好,请补充一下映射文档哈,相当于转写思路的描述。不然会造成文档缺失,这个后面如果再让其他同学来写,肯定也没有你对这几个API的转写思路更清楚~

@Liyulingyue
Copy link
Contributor Author

Liyulingyue commented Aug 28, 2023

整理了一下,目前映射关系的情况如下 @zhwesky2010

No. 69 torch.nn.functional.cosine_embedding_loss 文档已存在
No. 66 torch.nn.functional.gumbel_softmax PaddlePaddle/docs#6146
No. 70 torch.nn.functional.hinge_embedding_loss 文档已存在
No. 67 torch.nn.functional.pairwise_distance 文档已存在
No. 68 torch.nn.functional.poisson_nll_loss 文档已存在

@luotao1
Copy link
Collaborator

luotao1 commented Aug 29, 2023

torch.nn.functional.cosine_embedding_loss 文档已存在
torch.nn.functional.gumbel_softmax PaddlePaddle/docs#6146
torch.nn.functional.hinge_embedding_loss 文档已存在
torch.nn.functional.pairwise_distance 文档已存在
torch.nn.functional.poisson_nll_loss 文档已存在

@Liyulingyue 每一行标一下No.xxx吧

@Liyulingyue Liyulingyue changed the title 转换规则No67 torch.nn.functional.pairwise_distance 转换规则No66-70 torch.nn.functional.pairwise_distance Sep 1, 2023
@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Sep 5, 2023

torch.nn.functional.cosine_embedding_loss 文档已存在
torch.nn.functional.gumbel_softmax PaddlePaddle/docs#6146
torch.nn.functional.hinge_embedding_loss 文档已存在
torch.nn.functional.pairwise_distance 文档已存在
torch.nn.functional.poisson_nll_loss 文档已存在

@Liyulingyue 每一行标一下No.xxx吧

请问 No. 67 torch.nn.functional.pairwise_distance、No. 68 torch.nn.functional.poisson_nll_loss 的文档在哪里

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Sep 5, 2023

@Liyulingyue 这个PR还有些问题,我合入了我自己来修吧

@zhwesky2010 zhwesky2010 merged commit 28bd088 into PaddlePaddle:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants