转换规则 No.240-242. #119
Merged
转换规则 No.240-242. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ROckDog22
reviewed
Jun 25, 2023
paconvert/api_matcher.py
Outdated
| class RandomSplitMatcher(BaseMatcher): | ||
| def generate_code(self, kwargs): | ||
| if "lengths" in kwargs: | ||
| API_TEMPLATE = textwrap.dedent( |
There was a problem hiding this comment.
这个lengths参数能绕过吗，把浮点数转化为int类型
There was a problem hiding this comment.
这里不判断，然后生成的代码里判断lengths是浮点就转换成int类型的意思吗？
|
参考torch版本的random_split对lengths的处理修改了一下。 |
ROckDog22
reviewed
Jun 26, 2023
paconvert/api_matcher.py
Outdated
| def generate_code(self, kwargs): | ||
| API_TEMPLATE = textwrap.dedent( | ||
| """ | ||
| import math |
There was a problem hiding this comment.
转换的前提是已经确保torch代码是正确的，这里因为torch对应的API已经验证过了，可不可以只判断length是不是浮点数，这样的话就不需要再import math了
ROckDog22
reviewed
Jun 26, 2023
|
|
||
|
|
||
| def test_case_1(): | ||
| pytorch_code = textwrap.dedent( |
There was a problem hiding this comment.
可以添加一些length是int类型的，以及带有参数名称的单测，这样是不是测的全一些
|
LGTM |
ROckDog22
approved these changes
Jun 26, 2023
|
hi, @txyugood
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
PaddlePaddle/docs#5951
from_dlpack与to_dlpack的映射文档已存在。
PR APIs
#112