Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则 No.234/236/237 #133

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Conversation

txyugood
Copy link
Contributor

PR Docs

PaddlePaddle/docs#5978

PR APIs

torch.utils.data.TensorDataset
torch.utils.data.ChainDataset
torch.utils.data.Subset

#112

@paddle-bot
Copy link

paddle-bot bot commented Jun 27, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 27, 2023
@txyugood txyugood closed this Jun 27, 2023
@txyugood txyugood reopened this Jun 27, 2023
@txyugood txyugood changed the title 规则转换 No.234/236/237 转换规则 No.234/236/237 Jun 27, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 27, 2023
@ROckDog22
Copy link
Contributor

解决下冲突

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023

CLA assistant check
All committers have signed the CLA.

@txyugood
Copy link
Contributor Author

txyugood commented Jun 28, 2023

解决下冲突

Done.

ROckDog22
ROckDog22 previously approved these changes Jul 3, 2023
@ROckDog22
Copy link
Contributor

解决下冲突

ROckDog22
ROckDog22 previously approved these changes Jul 4, 2023
class TensorDatasetMatcher(BaseMatcher):
def get_paddle_nodes(self, args, kwargs):
new_args = self.parse_args(args)
code = "[{}".format(new_args[0])
Copy link
Collaborator

@zhwesky2010 zhwesky2010 Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是一个参数,不是最后的code,建议这个变量命名换个名字

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@zhwesky2010 zhwesky2010 merged commit 9d691cc into PaddlePaddle:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: not progressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants