转换规则 No.16/17/18 #142
Merged
转换规则 No.16/17/18 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
@Vooolta ，CI已全通过，本地测试pytest成功，麻烦有空的时候审核一下，谢谢！ |
ROckDog22
previously approved these changes
Jun 29, 2023
zhwesky2010
reviewed
Jun 29, 2023
paconvert/api_matcher.py
Outdated
| class SearchsortedMatcher(BaseMatcher): | ||
| def generate_code(self, kwargs): | ||
|
|
||
| if "side" in kwargs and kwargs["side"] is not None: |
There was a problem hiding this comment.
side应该不能传入None吧，只能是 'left' 和 'right'
There was a problem hiding this comment.
是的，经测试这里的kwargs是用户给定的kwargs, 即当用户没有显示设置side参数时，'side' no in kwargs 是True的。
def test_case_1():
pytorch_code = textwrap.dedent(
"""
import torch
x = torch.tensor([[ 1, 3, 5, 7, 9],
[ 2, 4, 6, 8, 10]])
values = torch.tensor([[3, 6, 9],
[3, 6, 9]])
result = torch.searchsorted(x, values)
"""
)
obj.run(pytorch_code, ["result"])如这里的测试案例1，kwargs = {'sorted_sequence':x, 'values':values}。
我不太清楚我这样的理解正不正确？但是在去除kwargs['side']的判断之后，test_case_1会报KeyError: 'side'的错误。
There was a problem hiding this comment.
这里应该不用判断None，只需判断if "side" in kwargs就行了
ROckDog22
reviewed
Jul 3, 2023
paconvert/api_matcher.py
Outdated
| class SearchsortedMatcher(BaseMatcher): | ||
| def generate_code(self, kwargs): | ||
|
|
||
| if "side" in kwargs and kwargs["side"] is not None: |
There was a problem hiding this comment.
这里应该不用判断None，只需判断if "side" in kwargs就行了
|
Done |
ROckDog22
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
PaddlePaddle/docs#5955
PR APIs