Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则 No.26 torch.svd #160

Merged
merged 11 commits into from
Aug 21, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Jul 9, 2023

PR Docs

文档已存在

PR APIs

torch.svd

@paddle-bot
Copy link

paddle-bot bot commented Jul 9, 2023

Thanks for your contribution!

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 11, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 11, 2023
paconvert/api_matcher.py Show resolved Hide resolved
paconvert/api_matcher.py Outdated Show resolved Hide resolved
tests/test_svd.py Outdated Show resolved Hide resolved
@zhwesky2010
Copy link
Collaborator

compute_uv=False这个看起来会影响计算结果啊,要么需要找到组合实现的方式转写,要么就return None。直接删掉应该会导致compute_uv=False时计算结果不对

@GreatV
Copy link
Contributor Author

GreatV commented Jul 12, 2023

修改成了 compute_uv=False return None

paconvert/api_matcher.py Outdated Show resolved Hide resolved
tests/test_svd.py Show resolved Hide resolved
paconvert/api_matcher.py Outdated Show resolved Hide resolved
paconvert/api_matcher.py Show resolved Hide resolved
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 6f23517 into PaddlePaddle:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants