-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
转换规则 No.26 torch.svd
#160
Merged
zhwesky2010
merged 11 commits into
PaddlePaddle:master
from
GreatV:add_conver_rule_No.26
Aug 21, 2023
Merged
转换规则 No.26 torch.svd
#160
zhwesky2010
merged 11 commits into
PaddlePaddle:master
from
GreatV:add_conver_rule_No.26
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
zhwesky2010
reviewed
Jul 11, 2023
zhwesky2010
reviewed
Jul 11, 2023
compute_uv=False这个看起来会影响计算结果啊,要么需要找到组合实现的方式转写,要么就return None。直接删掉应该会导致compute_uv=False时计算结果不对 |
修改成了 |
zhwesky2010
reviewed
Jul 13, 2023
zhwesky2010
reviewed
Jul 18, 2023
zhwesky2010
reviewed
Jul 18, 2023
zhwesky2010
reviewed
Jul 21, 2023
zhwesky2010
reviewed
Aug 4, 2023
zhwesky2010
reviewed
Aug 18, 2023
zhwesky2010
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
文档已存在
PR APIs