Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则 No. 94/95/96 #193

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

Atlantisming
Copy link
Contributor

@Atlantisming Atlantisming commented Jul 25, 2023

PR Docs

PR APIs

paddle.tensor.polygamma
paddle.tensor.qr
paddle.tensor.nanquantile

#112
对应文档

疑问:
1、torch.qr 会在未来版本改为 torch.linalg.qr() 与 paddle.linalg.qr() 对齐,可能到时需要修改。
2、torch.nanquantile 的参数 q 和 dim 不支持 list 类型。参考了#167 没有加入相关单测。

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Jul 26, 2023

@Atlantisming

  1. torch.qr与torch.linalg.qr分别编写文档和转换规则,各按各的来,互不干扰
  2. 这个分析工作是torch->paddle的单向工作,所以需要关注paddle缺失的功能不要关注torch缺失的功能,把握好 torch-> paddle的思路,先列举出torch的所有用法再对比

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 81747bf into PaddlePaddle:master Jul 26, 2023
@Atlantisming Atlantisming deleted the add94_96 branch July 26, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants