Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则 No.86 #202

Merged
merged 2 commits into from
Aug 3, 2023
Merged

转换规则 No.86 #202

merged 2 commits into from
Aug 3, 2023

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 27, 2023

PR Docs

#112

086 torch.Tensor.is_signed PaddlePaddle/docs#6054

PR APIs

086 torch.Tensor.is_signed 组合替代实现,node比较增加ast.Compare类型

@paddle-bot
Copy link

paddle-bot bot commented Jul 27, 2023

Thanks for your contribution!

@co63oc co63oc changed the title 转换规则 No.86/87 转换规则 No.86 Jul 27, 2023
paddle_class = self.paddleClass
code = "{}.dtype not in [paddle.uint8]".format(paddle_class)
node = ast.parse(code.strip("\n")).body
return node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return ast.parse(code.strip("\n")).body

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

"torch.Tensor.is_signed": {},
"torch.Tensor.is_signed": {
"Matcher": "TensorIsSignedMatcher",
"paddle_api": "paddle.Tensor.dtype"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

组合实现也不用填paddle_api了,与单个API的差异比较大,依赖多个组合,因此无需填写

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 31, 2023
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 0675271 into PaddlePaddle:master Aug 3, 2023
@co63oc co63oc deleted the api87 branch September 7, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants