Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则 No. 362 #239

Merged
merged 2 commits into from
Aug 25, 2023
Merged

转换规则 No. 362 #239

merged 2 commits into from
Aug 25, 2023

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Aug 22, 2023

PR Docs

#112

映射文档 PaddlePaddle/docs#6114

362 torch.special.softmax

PR APIs

@paddle-bot
Copy link

paddle-bot bot commented Aug 22, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 22, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 22, 2023
@@ -10262,6 +10262,19 @@
"out"
]
},
"torch.special.softmax": {
"Matcher": "FunctionalSoftmaxMatcher",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用这个FunctionalSoftmaxMatcher的原因是torch.nn.functional.softmax/log_softmax 与 Paddle存在某些差异,torch的dim可以不输入,且默认计算的值与paddle不同。

infoflow 2023-08-23 20-14-46

torch.special.softmax 的dim是必须输入的,所以没这个问题,这里可以直接使用GenericMatcher即可

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit a8d6094 into PaddlePaddle:master Aug 25, 2023
@co63oc co63oc deleted the api362 branch August 30, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants