Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore file changes caused by pre-commit #27105

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Restore file changes caused by pre-commit #27105

merged 3 commits into from
Sep 8, 2020

Conversation

Avin0323
Copy link
Contributor

@Avin0323 Avin0323 commented Sep 7, 2020

PR types

Others

PR changes

Others

Describe

generate_upstream_develop_api_spec can't run successful when check_style failed, the example can find in PR-CI-CPU-Py2. The reason is that file changes by per-commit in check_style stage.
image

Restore file changes before create new branch via git checkout .. There is a test log in PR-CI-CPU-Py2.
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 7, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Avin0323 Avin0323 changed the title Restore file changes caused by pre-commit and test it, test=document_fix Restore file changes caused by pre-commit Sep 7, 2020
Copy link
Contributor

@lelelelelez lelelelelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit ed2f57c into PaddlePaddle:develop Sep 8, 2020
@Avin0323 Avin0323 deleted the restore-changes-before-generate branch September 8, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants