Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary requirements #27341

Merged

Conversation

zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Sep 16, 2020

PR types

Others

PR changes

Others

Describe

Remove unnecessary requirements

  • objgraph
    It is only used in _print_debug_msg which is outdated after several upgrades of dygraph. It can be removed.
    So objgraph is removed from requirements.txt.

  • graphviz
    It is not used in paddle's codebase.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhiqiu zhiqiu requested a review from phlrain September 16, 2020 07:44
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit 189e10f into PaddlePaddle:develop Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants