Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2stat] Add Ptb Lm Test for V2 APIs #27461

Merged
merged 22 commits into from
Sep 29, 2020

Conversation

zhhsplendid
Copy link
Member

@zhhsplendid zhhsplendid commented Sep 22, 2020

PR types

Others

PR changes

Others

Describe

Add Ptb lm Test for V2 APIs.

We used tool from https://www.paddlepaddle.org.cn/documentation/docs/zh/2.0-beta/guides/migration_cn.html#paddle1-xpaddle2-0beta to do v1.x to v2 transformation.

This PR pulled changes from #27430, please DO NOT merge before #27430 is merged

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Aurelius84
Aurelius84 previously approved these changes Sep 29, 2020
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liym27
liym27 previously approved these changes Sep 29, 2020
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


Mark paddle.fluid.layers.reshape -> paddle.reshape

@zhhsplendid
Copy link
Member Author

LGTM.

Mark paddle.fluid.layers.reshape -> paddle.reshape

Not only that, I found more and I'm going to change

@zhhsplendid zhhsplendid dismissed stale reviews from liym27 and Aurelius84 via 85b9816 September 29, 2020 08:31
@zhhsplendid
Copy link
Member Author

Refine all fluid APIs except Embedding which is different to 2.0 Embedding

@Aurelius84 Aurelius84 self-requested a review September 29, 2020 08:35
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit 28f83f0 into PaddlePaddle:develop Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants