fix the precision problem of test_distribution #27524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
reason for test_distribution failure
Because
assign
op does not support the input of numpy.ndarray whose dtype isFP64
.When users set
FP64 numpy.ndarray
as the parameters ofUniform
andNormal
classes. We need to useassign
op to convert it toFP32 Tensor
. And then usecast
op to convert it to aFP64 Tensor
.There is a loss of accuracy in this conversion.
Refer to PR fix dtype not matching bug in log_prob and probs method of Distribution class #26767 .
In test_distribution, compare the output of paddle and output of numpy to verify the correction.
In
Uniform(low, high)
, the formula to calculate the entropy isentropy(low, high) = log (high - low)
.if
low
andhigh
are very close,high - low
will be close to0
, and small precision loss will become large error because of usinglog
.solution
In the realization of the original
Uniform
unittest, the range oflow
is [-1, 1), the range ofhigh
is [-5, 5).To avoid
low
andhigh
being too close, setlow
in the range of [-1, 1), and sethigh
in range of [5, 15).What's more, add a unittest to discuss the situation that
high < low
.log_prob
unittest ofNormal
class also fails, change the tolerance from 1e-6 to 1e-4.tolerance: 1e-6 -> 1e-4