Add shellcheck tools and modify copyright hook #27722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… addshellcheck
lanxianghit
reviewed
Oct 9, 2020
|
|
||
| COPYRIGHT = ''' | ||
| Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. | ||
| COPYRIGHT = '''Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Will be replaced by the current year in running.
luotao1
reviewed
Oct 12, 2020
| @@ -26,7 +26,7 @@ RUN rm -rf /temp_gcc82 && rm -rf /gcc-8.2.0.tar.xz && rm -rf /gcc-8.2.0 | |||
| RUN apt-get update && \ | |||
| apt-get install -y make build-essential libssl-dev zlib1g-dev libbz2-dev \ | |||
| libreadline-dev libsqlite3-dev wget curl llvm libncurses5-dev libncursesw5-dev \ | |||
| xz-utils tk-dev libffi-dev liblzma-dev openmpi-bin openmpi-doc libopenmpi-dev | |||
| xz-utils tk-dev libffi-dev liblzma-dev openmpi-bin openmpi-doc libopenmpi-dev shellcheck | |||
There was a problem hiding this comment.
除了CI上的镜像要添加shellcheck，开发镜像也要添加 @tianshuo78520a 请帮忙看下开发镜像要添加到哪里
… addshellcheck
test=develop
gongweibao
force-pushed
the
addshellcheck
branch
from
b3b69f6
to
16ce3ff
Compare
lanxianghit
approved these changes
Oct 12, 2020
kolinwei
approved these changes
Oct 13, 2020
chalsliu
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
How to fix large files:
#27905