Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dy2static test_lac predictor run case #27844

Merged
merged 8 commits into from
Oct 13, 2020

Conversation

OliverLPH
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Since test_lac may fail because random data input cause predcitor-run segmentation fault, now remove this part.
"train -> prediction" process are also covered by other unittests.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chalsliu chalsliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Oct 12, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Oct 12, 2020
@OliverLPH OliverLPH merged commit af57537 into PaddlePaddle:develop Oct 13, 2020
@OliverLPH OliverLPH deleted the rm_test_lac_predictor branch October 13, 2020 01:58
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants