Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kunlun add op #27890

Merged
merged 5 commits into from
Oct 14, 2020
Merged

kunlun add op #27890

merged 5 commits into from
Oct 14, 2020

Conversation

LDOUBLEV
Copy link
Contributor

PR types

New features

PR changes

OPs

Describe

add xpu op

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangting2020
Copy link
Contributor

理论上具备反向的算子都应该写grad kernel的,stack和roi_align 的xpu没有反向kernel,后期需要修复。以下2点需要注意

  • 与PR负责人确认过,本次只涉及迁移,新增的内容会建立TODO 卡片给相关负责同学。
  • skip_check_grad_ci是是为了豁免一些特殊的不需要进行梯度检查的单测的。该PR中涉及的单测本应该进行梯度检查,但是由于未支持,暂且approve,后续修复后,需要将skip_check_grad_ci删除。

Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for skip_check_grad_ci

@ceci3 ceci3 merged commit b0edda4 into PaddlePaddle:develop Oct 14, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
* add stack pool2d roi_align xpu op,test=kunlun

* error message opt, test=kunlun

* add xpu unittest,test=kunlun

* skip check grad,test=kunlun

* fix boostget , test=kunlun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants