Catch exception in download #28090
Merged
Catch exception in download #28090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
zhiqiu
reviewed
Oct 20, 2020
| if log_index % log_interval == 0: | ||
| sys.stderr.write(".") | ||
| sys.stdout.flush() | ||
| except Exception as e: |
There was a problem hiding this comment.
Please set a retry time, otherwise, it may result in an infinite loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
第三方request库 在网络异常得时候会抛出异常，添加catch机制，在出异常的时候，能执行re-try流程