[Unify Tensors PR #1] Replaced pten::Allocation with shared_ptr<memory::Allocation> for Storage #38301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
…faces accordingly
jim19930609
force-pushed
the
allocation_rearrange_pr
branch
from
8f19489
to
23ce28d
Compare
… allocation_rearrange_pr
jim19930609
changed the title
… allocation_rearrange_pr
paddle/pten/core/allocator.h
Outdated
| @@ -15,6 +15,7 @@ limitations under the License. */ | |||
| #pragma once | |||
|
|
|||
There was a problem hiding this comment.
不建议改这个文件，Tensor 可将接收的 Allocator 从 pten::Allocator 改为 memory::Allocator。
There was a problem hiding this comment.
Per offline discussion, replaced AllocateShared() interface with a virtual place() method.
Shixiaowei02
requested changes
Dec 23, 2021
… allocation_rearrange_pr PaddlePaddle#2
jim19930609
force-pushed
the
allocation_rearrange_pr
branch
from
160c131
to
8c08dc6
Compare
paddle/pten/core/allocator.h
Outdated
| @@ -15,6 +15,7 @@ limitations under the License. */ | |||
| #pragma once | |||
|
|
|||
| #include <cstdint> | |||
| #include "paddle/fluid/memory/memory.h" | |||
… allocation_rearrange_pr
jim19930609
force-pushed
the
allocation_rearrange_pr
branch
from
e37c48b
to
c8f31ba
Compare
Shixiaowei02
approved these changes
Dec 24, 2021
chenwhql
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Replaced pten::Allocation with shared_ptrmemory::Allocation for Storage.