Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DoubleGrad PR #5] Enabled gradient computations for grad_tensors passed to paddle.grad() #41198

Merged
merged 31 commits into from
Apr 2, 2022
Merged

[DoubleGrad PR #5] Enabled gradient computations for grad_tensors passed to paddle.grad() #41198

merged 31 commits into from
Apr 2, 2022

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Mar 31, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

[DoubleGrad PR #5] Enabled gradient computations for grad_tensors passed to paddle.grad()

  1. Added "CopyValueFromTensor" method to GradTensorHolder, used for setting up grad_tensor_holders at "backward" entrance.
  2. Replaced "TensorAdd" method with "add_dygraph_function" to perform gradient accumulation. (in GradTensorHolder::add()).
  3. Fixed an issue with RetainGradHook, the return Tensor of which used to not copying underlying AutogradMeta.

@jim19930609
[Refactor] refactored eager_gen.py PR PaddlePaddle#2
5e95fd1
@jim19930609
[DoubleGrad PR PaddlePaddle#1] Decoupled code generation logics for D…
214ad36 
…ygraph ForwardFunctions and GradNodes
@jim19930609
Fixed minor issue
14ebc19
@jim19930609
Merged develop
62179ba
@jim19930609
Merged develop from [PaddlePaddle#40935] Bug fix for intermediate sup…
2a83dd9 
…port in Yaml
@jim19930609
Adjusted logics of GenerateNodeCreationCodes and GenerateForwardDefin…
9e7ecf6 
…ition
@jim19930609
Fixed issues
b945424
@jim19930609
Merged develop
033913c
@jim19930609
Supported higher-order grad node generation
84ea03e
@jim19930609
Merge branch 'refactored_node_creation_codes' of https://github.com/j…
f29de18 
…im19930609/Paddle into support_double_grad_node_generation
@jim19930609
[DoubleGrad PR PaddlePaddle#4] Supported higher-order GradNode genera…
6117fd1 
…tion
@jim19930609
Merged develop
8785075
@jim19930609
Merged develop
f647fb4
@jim19930609
[DoubleGrad PaddlePaddle#4] Bug Fixes to Double Grad Node Generation
244f6da
@jim19930609
Merged develop
d17aaef
@jim19930609
Fixed yaml typo
4001488
@jim19930609
Merge branch 'support_double_grad_node_generation' of https://github.…
564f04b 
…com/jim19930609/Paddle into optimized_double_grad
@jim19930609
Fixed yaml typo
e26b572
@jim19930609
Merge branch 'support_double_grad_node_generation' of https://github.…
abfef59 
…com/jim19930609/Paddle into optimized_double_grad
@jim19930609
merged develop
a16f769
@jim19930609
merged develop
ca4fe62
@jim19930609
fixed minor issues
1b5fdb5
@jim19930609
merged develop
c542869
@jim19930609
[DoubleGrad PR PaddlePaddle#5] Enabled gradient computations for grad…
a3ce1a9 
…_tensors passed to paddle.grad()
@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

JiabinYang
JiabinYang approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim19930609 jim19930609 merged commit afadb8c into PaddlePaddle:develop Apr 2, 2022
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiabinYang JiabinYang JiabinYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jim19930609 @JiabinYang