-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python code style checking #412
Conversation
@QiJune Please resolve the conflicts first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this PR into multiple PRs:
- Just checkin code format tools
- Format demo's code
- Format python's code
- ...
Then, please assignment them into different people to review.
This PR make my chrome hang, and cost 2-3G memory to give one line comments.
dense_vector(settings.img_raw_size), # image feature | ||
integer_value(settings.num_classes)] # labels | ||
dense_vector(settings.img_raw_size), # image feature | ||
integer_value(settings.num_classes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment on this line.
@@ -13,9 +13,9 @@ | |||
# limitations under the License. | |||
|
|||
o = open("./" + "train.list", "w") | |||
o.write("./data/raw_data/train" +"\n") | |||
o.write("./data/raw_data/train" + "\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个很奇怪呀?直接把\n加到字符串里不就好了
dense_vector(settings.img_input_size), # image feature | ||
integer_value(1)] # labels | ||
dense_vector(settings.img_input_size), # image feature | ||
integer_value(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment one this line
Also bad for github, we must shrink PR within 2000-5000 lines, because chrome will cost too many memory. |
* add fom lite training * add fom lite training * modify according to review * modify according to review * fix error of fom trian error
1 use yapf( https://github.com/google/yapf)tool to format python code, and add .style.yapf config file #254
2 contributors can add a git hooks to auto-format changed python code just like this