Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NewIR]Gen ops_api.cc for static mode #56653

Merged
merged 15 commits into from
Aug 30, 2023
Merged

[NewIR]Gen ops_api.cc for static mode #56653

merged 15 commits into from
Aug 30, 2023

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Aug 25, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

生成的api如下

static PyObject *angle(PyObject *self, PyObject *args, PyObject *kwargs) {
  return static_api_angle(self, args, kwargs);
}

Pcard-67164

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@0x45f 0x45f merged commit 59b2ad3 into PaddlePaddle:develop Aug 30, 2023
@0x45f 0x45f deleted the gen-ops-api branch August 30, 2023 06:24
@0x45f 0x45f mentioned this pull request Aug 31, 2023
Closed
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@0x45f @BeingGod
[NewIR]Gen ops_api.cc for static mode (PaddlePaddle#56653)
8a5369b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@jzhang533 jzhang533 Awaiting requested review from jzhang533

@Aurelius84 Aurelius84 Awaiting requested review from Aurelius84

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0x45f @YuanRisheng @XiaoguangHu01 @sunzhongkai588 @zhangbo9674