-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR API adaptor No.222】Migrate paddle.nn.SyncBatchNorm into pir #59077
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
1d92238
to
08a404a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还遗漏了 test/legacy_test/test_sync_batch_norm_op.py 这个文件下的相关静态图单测~
@@ -359,12 +360,15 @@ def setUp(self): | |||
|
|||
|
|||
class TestDygraphSyncBatchNormAPIError(unittest.TestCase): | |||
@test_with_pir_api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看到 ci-coverage 挂在了这个地方。可以先取消 TestDygraphSyncBatchNormAPIError
单测的 pir 适配。并在 pr 描述里说明一下该单测暂不支持,并更新单测覆盖率
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看到 ci-coverage 挂在了这个地方。可以先取消
TestDygraphSyncBatchNormAPIError
单测的 pir 适配。并在 pr 描述里说明一下该单测暂不支持,并更新单测覆盖率
已更新,麻烦review~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
在 pr 描述里写一下 TestSyncBatchNormOpTraining 暂时不适配,然后更新一下单测覆盖率
PR types
Others
PR changes
APIs
Description
#58067
No.222 paddle.nn.SyncBatchNorm
PIR API 推全升级
将 paddle.nn.SyncBatchNorm 迁移升级至 pir,并更新单测 单测覆盖率:3/4
TestSyncBatchNormOpTraining测试比较复杂无法直接适配pir,暂时没有适配
存在问题: