【PIR Dist Op Reg No.3】 reg c_allreduce_min #60584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
kangguangli
reviewed
Jan 8, 2024
kangguangli
reviewed
Jan 11, 2024
|
可以rerun一下CI,应该可以合入了 |
already done. thanks |
kangguangli
approved these changes
Jan 24, 2024
zyfncg
approved these changes
Jan 24, 2024
Comment on lines
+116
to
+117
| 'c_allreduce_min', | ||
| 'c_allreduce_min_', |
There was a problem hiding this comment.
这些算子名单可以考虑优化下，多处黑白名单不利于长期维护
There was a problem hiding this comment.
这两处的用途不一样，名单也不完全重合，第二类主要是针对struct kernel，我觉得可能可以优化，之后研究下。
| @@ -55,6 +55,7 @@ const std::unordered_set<std::string> LegacyOpList = { | |||
| CReduceSumOp::name(), | |||
| CReduceSum_Op::name(), | |||
| CAllreduceMax_Op::name(), | |||
| CAllreduceMin_Op::name(), | |||
| @@ -55,6 +55,7 @@ const std::unordered_set<std::string> LegacyOpList = { | |||
| CReduceSumOp::name(), | |||
| CReduceSum_Op::name(), | |||
| CAllreduceMax_Op::name(), | |||
| CAllreduceMin_Op::name(), | |||
There was a problem hiding this comment.
这里为什么没有CAllreduceMinOp::name()?
There was a problem hiding this comment.
@enkilee 这里可以提个补充PR，这个PR我先合入吧
eee4017
pushed a commit
to eee4017/Paddle
that referenced
this pull request
Jan 30, 2024
* fix * fix * fix * fix * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
注册算子
c_allreduce_min