【PIR Dist Op Reg No.5】 reg partial_allgather #62735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
kangguangli
reviewed
Mar 18, 2024
| func: PartialAllgatherInferMeta | ||
| kernel : | ||
| func : partial_allgather | ||
| data_type : dtype |
There was a problem hiding this comment.
Suggested change
| data_type : dtype | |
| data_type : dtype |
为什么要添加这个呢？
另外，这个Op声明了PartialAllGatherOpInplaceInferer，所以需要额外声明inplace字段
inplace: (x->out)
There was a problem hiding this comment.
data_type这里我复制错了，感谢纠正～
kangguangli
approved these changes
Mar 19, 2024
kangguangli
approved these changes
Mar 19, 2024
zyfncg
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#60436
注册算子partial_allgather