Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tpm approval requirements in CI #64212

Merged
merged 1 commit into from
May 11, 2024

Conversation

jzhang533
Copy link
Contributor

PR Category

Others

PR Types

Others

Description

in our dev workflow, strictly requiring one of the tpm to review api change, and api doc change is no longer necessary.

Rational:

  • encourage individuals to seek reviews based on the open-source social structure rather than rigid org structure.
  • ask engineers with relevant context for reviews is more logical.
  • lower barrier to land a PR.

please ignore the following

PCard-67164

Copy link

paddle-bot bot commented May 11, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzhang533 jzhang533 merged commit 7626c3b into PaddlePaddle:develop May 11, 2024
30 of 31 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants