Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi stream thread pool #9578

Merged
merged 7 commits into from
Apr 13, 2018

Conversation

typhoonzero
Copy link
Contributor

Add feature supporting multiple thread pools that used for different purpose.

@typhoonzero typhoonzero changed the title Multi stream thread pool [WIP] Multi stream thread pool Apr 2, 2018
@typhoonzero typhoonzero changed the title [WIP] Multi stream thread pool Multi stream thread pool Apr 12, 2018
@@ -135,6 +135,17 @@ class ThreadPool {
std::condition_variable completed_;
};

class MultiStreamThreadPool : ThreadPool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the name MultiStream would be mixed up with cudaStream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@typhoonzero typhoonzero merged commit 1bdc726 into PaddlePaddle:develop Apr 13, 2018
@typhoonzero typhoonzero deleted the threadpool_for_io branch April 13, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants