Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

映射文档 No. 154/156/157 #6046

Merged
merged 2 commits into from
Jul 26, 2023
Merged

映射文档 No. 154/156/157 #6046

merged 2 commits into from
Jul 26, 2023

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 22, 2023

PaddlePaddle/PaConvert#112

154 torch.distributed.gather_object
156 torch.distributed.scatter_object_list
157 torch.distributed.reduce_scatter

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 24, 2023
@luotao1 luotao1 mentioned this pull request Jul 24, 2023
Closed
zhwesky2010
zhwesky2010 reviewed Jul 24, 2023
View reviewed changes
...ert/convert_from_pytorch/api_difference/distributed/torch.distributed.scatter_object_list.md Outdated
paddle.distributed.scatter_object_list(out_object_list, in_object_list, src=0, group=None)
```

其中 PyTorch 和 Paddle 功能一致，参数用法不一致，具体如下：
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看下面的描述，这个是 仅参数名不一致

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

...ert/convert_from_pytorch/api_difference/distributed/torch.distributed.scatter_object_list.md Outdated
@@ -0,0 +1,24 @@
## [参数不一致]torch.distributed.scatter_object_list
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是 仅参数名不一致 吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

zhwesky2010
zhwesky2010 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit f1ee531 into PaddlePaddle:develop Jul 26, 2023
2 checks passed
@co63oc co63oc mentioned this pull request Aug 30, 2023
Merged
@co63oc co63oc deleted the doc154 branch August 30, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

@ROckDog22 ROckDog22

Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@co63oc @zhwesky2010 @luotao1 @ROckDog22