Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee.fixed_generic_pkg-body.vhdl bug workaround #14

Merged

Conversation

LarsAsplund
Copy link
Contributor

This is a workaround for a bug in ieee.fixed_generic_pkg-body.vhdl. The bug is fixed in VHDL-2019 but it will probably be a while before all vendors have updated to support that standard revision

…he bug is fixed

in VHDL-2019 but it will probably be a while before all vendors have updated
to support that standard revision
@CLAassistant
Copy link

CLAassistant commented Jan 5, 2022

CLA assistant check
All committers have signed the CLA.

@Paebbels
Copy link
Owner

Paebbels commented Jan 5, 2022

@LarsAsplund where is the change? I don't see a diff except for formatting.

@LarsAsplund
Copy link
Contributor Author

There is a new variable byte_as_hex that makes sure that the string input to from_hex_string is indexed 1 to 2. If it indexed 3 to 4 or something else it fails. Some simulators will re-index the input to 1 to 2 when the function is called in which case there bug isn't triggered. ModelSim used to be like this, not sure now.

@Paebbels Paebbels merged commit 95e848b into Paebbels:master Jan 6, 2022
umarcor added a commit to dbhi/vunit that referenced this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants