Async: Fix warnings generated by clangd (IWYU)

Author: Pagghiu

Libraries/Async/Async.cpp

@@ -1,8 +1,7 @@
 // Copyright (c) Stefano Cristiano
 // SPDX-License-Identifier: MIT
-#include "../Containers/Internal/IntrusiveDoubleLinkedList.inl"
+#include "../Containers/Internal/IntrusiveDoubleLinkedList.inl" // IWYU pragma: keep
 #include "../Foundation/Platform.h"
-#include "../Socket/Socket.h"
 
 #include <string.h> // strncpy
 

Libraries/Async/Internal/AsyncInternal.h

@@ -13,6 +13,31 @@ struct SC::AsyncEventLoop::Internal
     struct KernelEventsIoURing;
     struct KernelQueue;
     struct KernelEvents;
+
+    struct KernelQueue
+    {
+        AlignedStorage<320> storage;
+
+        bool isEpoll = true;
+
+        KernelQueue();
+        ~KernelQueue();
+        KernelQueueIoURing& getUring();
+        KernelQueuePosix&   getPosix();
+
+        // On io_uring it doesn't make sense to run operations in a thread pool
+        [[nodiscard]] bool makesSenseToRunInThreadPool(AsyncRequest&) { return isEpoll; }
+
+        Result close();
+        Result createEventLoop(AsyncEventLoop::Options options);
+        Result createSharedWatchers(AsyncEventLoop&);
+        Result wakeUpFromExternalThread();
+
+        static Result associateExternallyCreatedSocket(SocketDescriptor&) { return Result(true); }
+        static Result associateExternallyCreatedFileDescriptor(FileDescriptor&) { return Result(true); }
+        static Result removeAllAssociationsFor(SocketDescriptor&) { return Result(true); }
+        static Result removeAllAssociationsFor(FileDescriptor&) { return Result(true); }
+    };
 #elif SC_PLATFORM_APPLE
     struct KernelQueuePosix;
     struct KernelEventsPosix;

Libraries/Async/Internal/AsyncLinux.inl

@@ -9,31 +9,6 @@
 #include <sys/syscall.h> // SYS_pidfd_open
 #include <sys/wait.h>    // waitpid
 
-struct SC::AsyncEventLoop::Internal::KernelQueue
-{
-    AlignedStorage<320> storage;
-
-    bool isEpoll = true;
-
-    KernelQueue();
-    ~KernelQueue();
-    KernelQueueIoURing& getUring();
-    KernelQueuePosix&   getPosix();
-
-    // On io_uring it doesn't make sense to run operations in a thread pool
-    [[nodiscard]] bool makesSenseToRunInThreadPool(AsyncRequest&) { return isEpoll; }
-
-    Result close();
-    Result createEventLoop(AsyncEventLoop::Options options);
-    Result createSharedWatchers(AsyncEventLoop&);
-    Result wakeUpFromExternalThread();
-
-    static Result associateExternallyCreatedSocket(SocketDescriptor&) { return Result(true); }
-    static Result associateExternallyCreatedFileDescriptor(FileDescriptor&) { return Result(true); }
-    static Result removeAllAssociationsFor(SocketDescriptor&) { return Result(true); }
-    static Result removeAllAssociationsFor(FileDescriptor&) { return Result(true); }
-};
-
 struct SC::AsyncEventLoop::Internal::KernelEvents
 {
     bool                  isEpoll = true;
@@ -73,7 +48,6 @@ struct SC::AsyncEventLoop::Internal::KernelEvents
     // clang-format on
 };
 
-#define SC_ASYNC_USE_EPOLL 1 // uses epoll
 #include "AsyncPosix.inl"
 
 #include "AsyncLinuxAPI.h"

Libraries/Async/Internal/AsyncLinuxAPI.h

@@ -1,4 +1,8 @@
 #include <dlfcn.h>
+#include <stdint.h>
+#include <string.h>
+#include <sys/uio.h> // for iovec
+#include <unistd.h>
 
 struct AsyncLinuxAPI
 {
@@ -148,7 +152,6 @@ struct AsyncLinuxLibURingLoader : public AsyncLinuxAPI
 //
 // TODO: Use the liburing-ffi supplied functions if they're available on the system
 
-#include <errno.h>            // errno
 #include <linux/io_uring.h>   // io_uring
 #include <linux/time_types.h> // __kernel_timespec
 

Libraries/Async/Internal/AsyncPosix.inl

@@ -1,9 +1,14 @@
 // Copyright (c) Stefano Cristiano
 // SPDX-License-Identifier: MIT
-
 #include "AsyncInternal.h"
 
+#include "../../Foundation/Assert.h"
 #include "../../Foundation/Deferred.h"
+#include "../../Socket/Socket.h"
+
+#if SC_PLATFORM_LINUX
+#define SC_ASYNC_USE_EPOLL 1 // uses epoll
+#endif
 
 #if SC_ASYNC_USE_EPOLL
 
@@ -15,6 +20,7 @@
 #include <sys/socket.h>   // For socket-related functions
 #include <sys/stat.h>     // fstat
 #include <sys/uio.h>      // writev, pwritev
+#include <sys/wait.h>     // waitpid / WIFEXITED / WEXITSTATUS
 
 #else
 
@@ -189,8 +195,7 @@ struct SC::AsyncEventLoop::Internal::KernelQueuePosix
         struct signalfd_siginfo siginfo;
         FileDescriptor::Handle  sigHandle;
 
-        const KernelQueuePosix& kernelQueue = result.eventLoop.internal.kernelQueue.get().getPosix();
-        Result res = kernelQueue.signalProcessExitDescriptor.get(sigHandle, Result::Error("Invalid signal handle"));
+        Result res = signalProcessExitDescriptor.get(sigHandle, Result::Error("Invalid signal handle"));
         if (not res)
         {
             return;

Libraries/Async/Internal/AsyncWindows.inl

@@ -8,6 +8,7 @@
 #include <Ws2tcpip.h> // sockadd_in6
 
 #include "../../Foundation/Deferred.h"
+#include "../../Socket/Socket.h"
 #include "AsyncInternal.h"
 #include "AsyncWindows.h"
 #include "AsyncWindowsAPI.h"