Process: Improve ProcessTest compatibility

Author: Pagghiu

Libraries/Process/Internal/ProcessPosix.inl

@@ -333,21 +333,3 @@ bool SC::ProcessEnvironment::get(size_t index, StringView& name, StringView& val
     }
     return true;
 }
-
-bool SC::ProcessEnvironment::contains(StringView variableName, size_t* index)
-{
-    for (size_t idx = 0; idx < numberOfEnvironment; ++idx)
-    {
-        StringView name, value;
-        SC_TRY(get(idx, name, value));
-        if (name == variableName)
-        {
-            if (index != nullptr)
-            {
-                *index = idx;
-            }
-            return true;
-        }
-    }
-    return false;
-}

Libraries/Process/Process.cpp

@@ -234,3 +234,25 @@ SC::Result SC::Process::setEnvironment(StringView name, StringView value)
     StringsArena table = {environment, environmentNumber, environmentByteOffset};
     return table.appendAsSingleString({name, SC_NATIVE_STR("="), value});
 }
+
+//-------------------------------------------------------------------------------------------------------
+// ProcessEnvironment
+//-------------------------------------------------------------------------------------------------------
+
+bool SC::ProcessEnvironment::contains(StringView variableName, size_t* index)
+{
+    for (size_t idx = 0; idx < numberOfEnvironment; ++idx)
+    {
+        StringView name, value;
+        SC_TRY(get(idx, name, value));
+        if (name == variableName)
+        {
+            if (index != nullptr)
+            {
+                *index = idx;
+            }
+            return true;
+        }
+    }
+    return false;
+}

Libraries/Process/Tests/ProcessTest.cpp

@@ -109,7 +109,7 @@ void SC::ProcessTest::processInheritStdout()
     }
     break;
     default: { // Posix
-        SC_TEST_EXPECT(Process().exec({"which", "sudo"}));
+        SC_TEST_EXPECT(Process().exec({"which", "su"}));
     }
     break;
     }
@@ -127,7 +127,7 @@ void SC::ProcessTest::processIgnoreStdout()
     }
     break;
     default: { // Posix
-        SC_TEST_EXPECT(Process().exec({"which", "sudo"}, Process::StdOut::Ignore()));
+        SC_TEST_EXPECT(Process().exec({"which", "su"}, Process::StdOut::Ignore()));
     }
     break;
     }
@@ -146,8 +146,8 @@ void SC::ProcessTest::processRedirectStdout()
     }
     break;
     default: { // Posix
-        SC_TEST_EXPECT(Process().exec({"which", "sudo"}, output));
-        SC_TEST_EXPECT(output.view() == "/usr/bin/sudo\n");
+        SC_TEST_EXPECT(Process().exec({"which", "su"}, output));
+        SC_TEST_EXPECT(output.view() == "/bin/su\n" or output.view() == "/usr/bin/su\n");
     }
     break;
     }