Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor daily_material plugin #780

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

♻️ Refactor daily_material plugin #780

wants to merge 9 commits into from

Conversation

karakoo
Copy link
Member

@karakoo karakoo commented Mar 16, 2024 •
edited
Loading

描述 / Description

  1. 插件名变更为 daily_farming
  2. 将素材表源从 honey impact 更换为 ambr
  3. 取消了使用刷新每日素材表指令时，会下载全部图标的任务（这个功能会分离至新的插件中）

更改检查表 / Change Checklist

  • 有插件命令更新
    • 已更新 bot 帮助文件
  • 有流程交互
    • 指引明确
    • 可以退出
  • 会触发频率限制
    • 有对应的限制措施
  • 需要用户输入数据
    • 验证用户数据
    • 如果是文件，检查了文件大小
    • 对保存的数据再次进行了验证
  • 添加了新的依赖包
  • 测试
    • 本地通过了测试
    • CI 通过了测试

说明 / Note

daily farming是从其他网站上看的，感觉这个翻译更准确

@karakoo
♻️ Refactor code
c6be4e4 
Plugin name changed to `daily_farming`
Change `honey impact` source to `ambr` source
@karakoo
🎨 Format the code
5f9d218
@karakoo
🔥 Remove the old plugin
d05035d
@karakoo karakoo self-assigned this Mar 16, 2024
@deepsource-autofix
style: format code with Black
77ba2bf 
This commit fixes the style issues introduced in d05035d according to the output
from Black.

Details: #780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@karakoo karakoo

Labels
Do not merge (yet) ⛔️ refactor ♻ Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karakoo