Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-driven ansible): Updated code for Red Hat's certification checks #479

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

jamesholland-uk
Copy link
Member

@jamesholland-uk jamesholland-uk commented Aug 14, 2023

Description

Updated code for Red Hat's certification checks. Fixes failure of checks executed by ruff with tox for EDA code.
UPDATE: Fixes clashed with ansible-sanity checks, so were backed out per review with Ansible Partner Engineering, and instead a skip was put in for the ruff test FA102.

Motivation and Context

The tox testing/linting tool required by Red Hat as part of EDA certification is not version pinned/ranged. The ruff tool (executed with tox) moved from 0.0.283 to 0.0.284, then we started to get new errors, with no changes to the code:

extensions/eda/plugins/event_source/logs.py:104:14: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
extensions/eda/plugins/event_source/logs.py:106:6: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection
extensions/eda/plugins/event_source/logs.py:148:11: FA102 Missing `from __future__ import annotations`, but uses PEP 585 collection

The changes in this PR provide fixes for these errors and the subsequent cascading errors during local testing with tox.
UPDATE: Not a fix, but a skip, see above.

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@jamesholland-uk jamesholland-uk merged commit 0fdce26 into develop Aug 15, 2023
16 checks passed
@jamesholland-uk jamesholland-uk deleted the update-eda-for-new-certification-checks branch August 15, 2023 19:13
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
### [2.17.4](v2.17.3...v2.17.4) (2023-08-15)

### Bug Fixes

* **event-driven ansible:** Update for Red Hat's certification checks ([#479](#479)) ([0fdce26](0fdce26))
@github-actions
Copy link

🎉 This PR is included in version 2.17.4 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant