Skip to content

Commit f210f67

Browse files
Update the rewriteForIde for new cb package version (#7242)
1 parent 6b035fd commit f210f67

4 files changed

+10
-9
lines changed

patches/server/0001-Setup-Gradle-project.patch

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ index 0000000000000000000000000000000000000000..75c858870a55f7282a0e3500f803cb33
5858
+ testImplementation("org.hamcrest:hamcrest-library:1.3")
5959
+}
6060
+
61+
+val craftbukkitPackageVersion = "1_18_R2" // Paper
6162
+tasks.jar {
6263
+ archiveClassifier.set("dev")
6364
+
@@ -89,8 +90,7 @@ index 0000000000000000000000000000000000000000..75c858870a55f7282a0e3500f803cb33
8990
+
9091
+relocation {
9192
+ // Order matters here - e.g. craftbukkit proper must be relocated before any of the libs are relocated into the cb package
92-
+ val packageVersion = "1_18_R2"
93-
+ relocate("org.bukkit.craftbukkit" to "org.bukkit.craftbukkit.v$packageVersion") {
93+
+ relocate("org.bukkit.craftbukkit" to "org.bukkit.craftbukkit.v$craftbukkitPackageVersion") {
9494
+ exclude("org.bukkit.craftbukkit.Main*")
9595
+ }
9696
+}

patches/server/0003-Build-system-changes.patch

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,21 @@ index 75c858870a55f7282a0e3500f803cb330b462f37..d39ed9a8a32913193aec1bba2a59a352
2121
runtimeOnly("org.xerial:sqlite-jdbc:3.36.0.3")
2222
runtimeOnly("mysql:mysql-connector-java:8.0.27")
2323

24-
@@ -32,6 +31,7 @@ tasks.jar {
24+
@@ -33,6 +32,7 @@ tasks.jar {
2525
val gitHash = git("rev-parse", "--short=7", "HEAD").getText().trim()
2626
val implementationVersion = System.getenv("BUILD_NUMBER") ?: "\"$gitHash\""
2727
val date = git("show", "-s", "--format=%ci", gitHash).getText().trim() // Paper
2828
+ val gitBranch = git("rev-parse", "--abbrev-ref", "HEAD").getText().trim() // Paper
2929
attributes(
3030
"Main-Class" to "org.bukkit.craftbukkit.Main",
3131
"Implementation-Title" to "CraftBukkit",
32-
@@ -40,6 +40,8 @@ tasks.jar {
32+
@@ -41,6 +41,9 @@ tasks.jar {
3333
"Specification-Title" to "Bukkit",
3434
"Specification-Version" to project.version,
3535
"Specification-Vendor" to "Bukkit Team",
3636
+ "Git-Branch" to gitBranch, // Paper
3737
+ "Git-Commit" to gitHash, // Paper
38+
+ "CraftBukkit-Package-Version" to craftbukkitPackageVersion, // Paper
3839
)
3940
for (tld in setOf("net", "com", "org")) {
4041
attributes("$tld/bukkit", "Sealed" to true)

patches/server/0266-Hook-into-CB-plugin-rewrites.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ our own relocation. Also lets us rewrite NMS calls for when we're
88
debugging in an IDE pre-relocate.
99

1010
diff --git a/src/main/java/org/bukkit/craftbukkit/util/Commodore.java b/src/main/java/org/bukkit/craftbukkit/util/Commodore.java
11-
index a679133a3de51e26eb19932ece9ade292879aefd..d5330d1dff2d02e585eba3ec7c48bf261cdce8ef 100644
11+
index a679133a3de51e26eb19932ece9ade292879aefd..89a32de0a3fbb7465b078b2aa1cc1d156a4a174d 100644
1212
--- a/src/main/java/org/bukkit/craftbukkit/util/Commodore.java
1313
+++ b/src/main/java/org/bukkit/craftbukkit/util/Commodore.java
1414
@@ -6,7 +6,9 @@ import java.io.FileOutputStream;
@@ -43,18 +43,18 @@ index a679133a3de51e26eb19932ece9ade292879aefd..d5330d1dff2d02e585eba3ec7c48bf26
4343

4444
+ // Paper start - Plugin rewrites
4545
+ private static final Map<String, String> SEARCH_AND_REMOVE = initReplacementsMap();
46+
+ private static final java.util.jar.Manifest manifest = io.papermc.paper.util.JarManifests.manifest(Commodore.class);
4647
+ private static Map<String, String> initReplacementsMap()
4748
+ {
4849
+ Map<String, String> getAndRemove = new HashMap<>();
4950
+ // Be wary of maven shade's relocations
5051
+ getAndRemove.put( "org/bukkit/".concat( "craftbukkit/libs/it/unimi/dsi/fastutil/" ), "org/bukkit/".concat( "craftbukkit/libs/" ) ); // Remap fastutil to our location
5152
+
52-
+ if ( Boolean.getBoolean( "debug.rewriteForIde" ) )
53+
+ if ( Boolean.getBoolean( "debug.rewriteForIde" ) && manifest != null)
5354
+ {
5455
+ // unversion incoming calls for pre-relocate debug work
55-
+ final String NMS_REVISION_PACKAGE = "v1_16_R3/";
56+
+ final String NMS_REVISION_PACKAGE = "v" + manifest.getMainAttributes().getValue("CraftBukkit-Package-Version") + "/";
5657
+
57-
+ getAndRemove.put( "net/minecraft/".concat( "server/" + NMS_REVISION_PACKAGE ), NMS_REVISION_PACKAGE );
5858
+ getAndRemove.put( "org/bukkit/".concat( "craftbukkit/" + NMS_REVISION_PACKAGE ), NMS_REVISION_PACKAGE );
5959
+ }
6060
+

patches/server/0412-Deobfuscate-stacktraces-in-log-messages-crash-report.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ index 1d7bbff8711bfb991046ecc66dce328a5f643c2d..2ea3af07a18094d0bc7e4898c0bb97ec
3333
testImplementation("junit:junit:4.13.2")
3434
testImplementation("org.hamcrest:hamcrest-library:1.3")
3535
}
36-
@@ -88,6 +93,45 @@ tasks.shadowJar {
36+
@@ -89,6 +94,45 @@ tasks.shadowJar {
3737
}
3838
}
3939

0 commit comments

Comments
 (0)