Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adventure fails to convert old sign text properly #5304

Closed
JRoy opened this issue Mar 4, 2021 · 1 comment
Closed

Adventure fails to convert old sign text properly #5304

JRoy opened this issue Mar 4, 2021 · 1 comment
Assignees
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. status: in progress Issue is currently being worked on type: bug Something doesn't work as it was intended to. version: 1.16 Game version 1.16

Comments

@JRoy
Copy link
Member

JRoy commented Mar 4, 2021

Issue Summary

A sign created with text §1[Buy] on Paper build 472 (build right before adventure) produces the following NBT for Text1:

{"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"dark_blue","text":"[Buy]"}],"text":""}

A sign created with text §1[Buy] on latest Paper build produces the following NBT for Text1:

{"color":"dark_blue","text":"[Buy]"}', Text2: '{"text":"1"}

When using Sign#getLine(int) (converts to legacy string), Paper 472 will convert the both of the above components to §1[Buy] which is the "correct" legacy string representation.

However, using Sign#getLine(int) with the first component on the latest Paper, it will produce §1[Buy]§r. This may be the correct way to convert the component but we shouldn't being doing this in order to maintain compatibility with (the broken I guess) upstream component conversion.

@Proximyst Proximyst added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. status: in progress Issue is currently being worked on type: bug Something doesn't work as it was intended to. version: 1.16 Game version 1.16 labels Mar 7, 2021
@kashike
Copy link
Member

kashike commented Mar 9, 2021

This should be fixed as of 27a8d99 and 7f72c46.

@kashike kashike closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. status: in progress Issue is currently being worked on type: bug Something doesn't work as it was intended to. version: 1.16 Game version 1.16
Projects
None yet
Development

No branches or pull requests

4 participants