Fix NotNull locales

[Moulberry]

Two methods returning locales are annotated @NotNull, despite being able to return null

[imDaniX]

Is there a reason why the default fallback is the US locale? I'd say if player's locale cannot be parsed, it'd better be something like Locale.ROOT, so we can check for that and act accordingly, like warning a player.

[olijeffers0n]

Is there a reason why the default fallback is the US locale? I'd say if player's locale cannot be parsed, it'd better be something like Locale.ROOT, so we can check for that and act accordingly, like warning a player.

Personally, I would say it is very standard to default to English. I am biased, but defaulting to the server's root Locale seems like it could cause issues

[imDaniX]

Personally, I would say it is very standard to default to English. I am biased, but defaulting to the server's root Locale seems like it could cause issues

Well, there's also Locale.ENGLISH which is used fairly often too, hence the question. Also, the root locale isn't "server's root locale", but rather a neutral one, as stated in its javadoc.

[Moulberry]

Is there a reason why the default fallback is the US locale? I'd say if player's locale cannot be parsed, it'd better be something like Locale.ROOT, so we can check for that and act accordingly, like warning a player.

Locale.US is the fallback locale used elsewhere:

Paper/patches/server/0010-Adventure.patch

Line 2763 in c5d168c

+ public java.util.Locale adventure$locale = java.util.Locale.US; // Paper

Paper/patches/server/0010-Adventure.patch

Line 1476 in c5d168c

+ : Locale.US

I don't mind Locale.ROOT, but consistency with the existing code is more important