Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlockState being set to null for damage events #10252

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix BlockState being set to null for damage events #10252

merged 1 commit into from
Feb 15, 2024

Conversation

Doc94
Copy link
Contributor

@Doc94 Doc94 commented Feb 14, 2024

This PR handle 2 things related to 31699ae

  • Fix the BlockState being set to null when the instance of DamageSource is cloned (i dont like the clone.. but was a solution for avoid registry things when make all this)
  • Add a missing paper comment in patch

@Doc94 Doc94 requested a review from a team as a code owner February 14, 2024 17:28
@kennytv kennytv merged commit 37df121 into PaperMC:master Feb 15, 2024
4 checks passed
@Doc94 Doc94 deleted the fix/no-ref/explodedBlockState-ignored-or-reset branch February 15, 2024 10:25
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
@Doc94 @lynxplay
Fix BlockState being set to null for damage events (PaperMC#10252)
a2e26e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytv kennytv kennytv approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doc94 @Machine-Maker @kennytv