Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to vanilla handling of LivingEntity#actuallyHurt #10463

Merged

Conversation

Machine-Maker
Copy link
Member

LivingEntity#actuallyHurt should only return false when the damage event is cancelled which then prevents logic in actuallyHurt's overrides from running. If the entity is invulnerable to the damage source or no damage happens for some other reason, the logic in the overrides should still be executed.

@Machine-Maker Machine-Maker requested a review from a team as a code owner April 27, 2024 16:50
@Machine-Maker Machine-Maker merged commit a771940 into PaperMC:dev/1.20.5 Apr 27, 2024
1 of 2 checks passed
@Machine-Maker Machine-Maker deleted the feature/vanilla-actuallyHurt branch April 27, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants