Revert to vanilla handling of LivingEntity#actuallyHurt #10463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
approved these changes
Apr 27, 2024
Machine-Maker
force-pushed
the
feature/vanilla-actuallyHurt
branch
from
a2a2d0e
to
4c70978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LivingEntity#actuallyHurtshould only returnfalsewhen the damage event is cancelled which then prevents logic inactuallyHurt's overrides from running. If the entity is invulnerable to the damage source or no damage happens for some other reason, the logic in the overrides should still be executed.