-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CraftMetaBlockState for data components #10731
Fix CraftMetaBlockState for data components #10731
Conversation
3501675
to
279a7c2
Compare
279a7c2
to
664d187
Compare
I found some more issues related to the beehive thing. the fix for that in this PR currently isn't correct and only fixes one instance of it. Fixing all of them will require more diff so am going back to draft until I get that done. |
664d187
to
bcac3b0
Compare
Ok, I think this is now the most correct fix for block entities and itemmeta. Instead of storing the data in a CraftBlockEntityState which will add a bunch of extra stuff, this changes it to 2 fields for the custom data and the rest of the components that apply to the specific block entity type. |
bcac3b0
to
7968ff8
Compare
029a960
to
575451b
Compare
d0fe354
to
878c55a
Compare
This will go on forever...
878c55a
to
198efa6
Compare
This will go on forever...
Upstream's "restorePatch" function doesn't actually apply the patch which will compare the patch values to the itemtype's implicit values and not include the component if they equal. This fixes #10697.
Download the paperclip jar for this pull request: paper-10731.zip