Auth system and forwarding changes #8199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I need to patch the signature enforcement field with the value defined in the config for velocity-online-mode, doing that now |
electronicboy
approved these changes
Jul 29, 2022
kennytv
requested changes
Jul 30, 2022
Comment on lines
+1
to
+10
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
| From: "FivePB (Xer)" <admin@fivepb.me> | ||
| Date: Thu, 28 Jul 2022 11:36:36 +0000 | ||
| Subject: [PATCH] Verify player key early | ||
|
|
||
| This patch refactors authentication with the player key in a way | ||
| that forces the key to be verified early using the (currently unused) | ||
| player UUID provided in the Server hello packet. | ||
| This helps verify connections early and may reduce requests to the session | ||
| service |
There was a problem hiding this comment.
This patch seems like unnecessarily high-conflict diff for too little benefit in a normal server scenario, since it doesn't help in any other important way with specific targetting etc.
... or just needs fixing the first if on key != null
|
Closed in favor of #8219 and following |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes modify the auth session handler to verify the player key early, if present.
This potentially saves session service requests on invalid connections.
The Velocity forwarding mode has also been updated to reflect the V2 key forwarding mode