Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Datapacks #8865

Closed

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Feb 19, 2023

Will clean up imports and move any plugin loading changes to the original patch later.
done

@Machine-Maker Machine-Maker force-pushed the feature/datapacks branch 6 times, most recently from 5d3a7ac to c833433 Compare February 21, 2023 04:42
@Machine-Maker Machine-Maker marked this pull request as ready for review February 21, 2023 04:47
@Machine-Maker Machine-Maker requested a review from a team as a code owner February 21, 2023 04:47
@Machine-Maker
Copy link
Member Author

Updated with latest plugin loading changes.

@Atten007
Copy link

Atten007 commented Aug 7, 2023

Is this still being worked on? Or can this be closed? I want to create a new website where new Minecraft plugins and data packs for PaperMC can be created, so I need this PR updated to 1.20 and merged to create the website.

@MiniDigger
Copy link
Member

paper already supports datapacks. this PR only adds support for plugins to provide a data pack, instead of requiring the server admin to place the datapack in the right folder. for more info please join our discord.
and yes, this PR is still something we want.

@metabrixkt
Copy link
Contributor

is this feature supposed to require plugins to have a bootstrapper even if they don't need one?

@Arian100
Copy link

Is this going to include support for resourcepacks?

@Malfrador
Copy link
Member

Is this going to include support for resourcepacks?

Resource packs are client-side only. The server can already send resource packs to the client using the server.properties configuration or the API.

@Arian100
Copy link

Is this going to include support for resourcepacks?

Resource packs are client-side only. The server can already send resource packs to the client using the server.properties configuration or the API.

I meant that you can for example add the resource pack to you plugin jar and set it in the plugin-yml and the server is going to automatically send it to players and merge the different resource packs form plugins.

@electronicboy
Copy link
Member

resource packs are entirely out of scope for datapcks

@Malfrador
Copy link
Member

Is this going to include support for resourcepacks?

Resource packs are client-side only. The server can already send resource packs to the client using the server.properties configuration or the API.

I meant that you can for example add the resource pack to you plugin jar and set it in the plugin-yml and the server is going to automatically send it to players and merge the different resource packs form plugins.

No. You can already do that using the API. The client supports multiple server resource packs, so merging them server-side is not necessary.
You would still need to host the pack somewhere, and Paper is not suddenly going to include a webserver.

@TetraTheta
Copy link
Contributor

I meant that you can for example add the resource pack to you plugin jar and set it in the plugin-yml and the server is going to automatically send it to players and merge the different resource packs form plugins.

I don't think that is in scope of this PR. To put it simply, it is not related to this PR.

@pontaoski
Copy link
Contributor

what's blocking this PR? willing to pick it up if @Machine-Maker doesn't have the time to work on this

@Leguan16
Copy link
Contributor

Leguan16 commented May 4, 2024

what's blocking this PR? willing to pick it up if @Machine-Maker doesn't have the time to work on this

probably low priority.

@Machine-Maker
Copy link
Member Author

Replaced by #10711 which uses the new lifecycle event system.

@Machine-Maker Machine-Maker deleted the feature/datapacks branch May 13, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

10 participants