Lazily create LootContext for criterions #9969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each player on each tick, enter block triggers are invoked, and these create loot contexts that are promptly thrown away since the trigger doesn't pass the predicate To avoid this, we now lazily create the LootContext if the criterion passes the predicate AND if any of the listener triggers require a loot context instance
patches/server/1053-Lazily-create-LootContext-for-criterions.patch
Outdated
Show resolved
Hide resolved
Machine-Maker
approved these changes
Nov 25, 2023
Owen1212055
approved these changes
Nov 25, 2023
lynxplay
pushed a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
For each player on each tick, enter block triggers are invoked, and these create loot contexts that are promptly thrown away since the trigger doesn't pass the predicate To avoid this, we now lazily create the LootContext if the criterion passes the predicate AND if any of the listener triggers require a loot context instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each player on each tick, enter block triggers are invoked, and these create loot contexts that are promptly thrown away since a lot of the times the predicate doesn't match. (in vanilla, it should only pass for the end gateway, or when the player is in water to get the boat's recipes, and iirc none of these requires a LootContext)
To avoid this, we now lazily create the LootContext if the criterion passes the predicate AND if any of the listener triggers require a loot context instance.
While the performance increase ain't that big (on a random profile with ~55 players on my server, the
createContextcall was using 0.10% according to spark), it would be nice to just avoid that useless allocation anyway, and theorically if you have a lot of players moving around, the performance impact of this call would be bigger.